Re: [PATCH 05/10] ksm: no debug in page_dup_rmap()

[Rik van Riel]

Izik Eidus wrote:
> From: Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx>
>
> page_dup_rmap(), used on each mapped page when forking,  was originally
> just an inline atomic_inc of mapcount.  2.6.22 added CONFIG_DEBUG_VM
> out-of-line checks to it, which would need to be ever-so-slightly
> complicated to allow for the PageKsm() we're about to define.
>
> But I think these checks never caught anything.  And if it's coding
> errors we're worried about, such checks should be in page_remove_rmap()
> too, not just when forking; whereas if it's pagetable corruption we're
> worried about, then they shouldn't be limited to CONFIG_DEBUG_VM.

Acked-by: Rik van Riel <riel@xxxxxxxxxx>

--
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/