Re: [PATCH 01/14] amd64_edac: simplify error type bits extractors

[Aristeu Rozanski]

Hi Borislav,
> -	/* If this was an 'observed' error, early out */
> -	if (ec_pp == K8_NBSL_PP_OBS)
> -		return;		/* We aren't the node involved */
> +
> +	/* Bail early out if this was an 'observed' error */
> +	if (((ec >> 9) & 0x3) == K8_NBSL_PP_OBS)
> +		return;
minor thing:
this patch and others makes me think if it wouldn't be better to have:
	#define PP(x)		(((x) >> 9) & 0x3)
	#define PP_MSG(x)	pp_msgs[PP(x)]
and the same for LL, TT, RRRR.

the rest of the patch series looks good to me

-- 
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/