Re: Commit 1e137f92 broke my Vaio VGN-FE550G's hda_intel driver.

From: Takashi Iwai
Date: Mon Jul 20 2009 - 09:14:34 EST


At Mon, 20 Jul 2009 07:26:23 -0500,
Robin Holt wrote:
>
> On Mon, Jul 20, 2009 at 08:00:31AM +0200, Takashi Iwai wrote:
> > At Sun, 19 Jul 2009 17:55:38 -0500,
> > Robin Holt wrote:
> > >
> > > > What about to pass model=vaio? Doesn't it work?
> > >
> > > That didn't change the behavior.
> > >
> > > > In anyways, please run alsa-info.sh with --no-upload option, and attach
> > > > the generated file.
> > >
> > > Here is the output from alsa-info.sh. This was from the module load without
> > > the model=vaio. Below, (search for ---Robin---) is the output from alsa-info.sh
> > > with model=vaio.
> >
> > Thanks. This look really like a bug. The pin definition was wrongly
> > placed. It should have been before the pin overrides.
> >
> > Could you try the patch below? With the patch, the driver would work
> > even without any model option.
>
> Patch worked perfectly.
>
> Acked-by: Robin Holt <holt@xxxxxxx>

Thanks, the patch is now in sound GIT tree.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/