Re: [PATCH] enable x2APIC without interrupt remapping under KVM

From: Ingo Molnar
Date: Sun Jul 19 2009 - 12:28:42 EST



* Gleb Natapov <gleb@xxxxxxxxxx> wrote:

> + if (!ret) {
> + /* IR is required if there is APIC ID > 255 even when running
> + * under KVM
> + */

Eeek.

> + if (x2apic_preenabled) {
> + panic("x2apic enabled by bios. But IR enabling failed."
> + " Check that CONFIG_X86_X2APIC and CONFIG_INTR_REMAP are"
> + " enabled.");

We dont want to break such messages mid-line, it makes it hard to
git-grep for them. Also, the '. But' looks weird.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/