Re: [PATCH -tip] tracing: use defined fields to print formats

From: Ingo Molnar
Date: Sat Jul 18 2009 - 07:30:36 EST



* Lai Jiangshan <laijs@xxxxxxxxxxxxxx> wrote:

> It seems that ftrace_format_##call() and
> ftrace_define_fields_##call() are duplicate more or less.
>
> trace_define_field() defines fields and links them into strcut
> ftrace_event_call. We reuse them to print formats and remove
> ftrace_format_##call(). It make all things simpler.
>
> TRACE_EVENT_FORMAT_NOFILTER is dropped. Because we should
> "trace_define_field()" fields for all struct ftrace_event_call,
> even it's no filter.
>
> Signed-off-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
> ---
> diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h
> index 5c093ff..738b33d 100644

Minor request for future patches: could you please include the
diffstat all the time? Makes it much easier to see the general
impact of a patch.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/