Re: [PATCH 2/2] linker script: unify usage of discard definition

[Sam Ravnborg]

On Wed, Jul 08, 2009 at 06:27:12PM +0900, Tejun Heo wrote:
> Discarded sections in different archs share some commonality but have
> considerable differences.  This led to linker script for each arch
> implementing its own /DISCARD/ definition, which makes maintaining
> tedious and adding new entries error-prone.
> 
> This patch makes all linker scripts to move discard definitions to the
> end of the linker script and use the common DISCARDS macro.  As ld
> uses the first matching section definition, archs can include default
> discarded sections by including them earlier in the linker script.
> 
> ia64 is notable because it first throws away some ia64 specific
> subsections and then include the rest of the sections into the final
> image, so those sections must be discarded before the inclusion.
> 
> defconfig compile tested for x86, x86-64, powerpc, powerpc64, ia64,
> alpha, sparc, sparc64 and s390.  Michal Simek tested microblaze.
> 
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Acked-by: Paul Mundt <lethal@xxxxxxxxxxxx>
> Acked-by: Mike Frysinger <vapier@xxxxxxxxxx>
> Tested-by: Michal Simek <monstr@xxxxxxxxx>
> Cc: linux-arch@xxxxxxxxxxxxxxx
> Cc: Michal Simek <monstr@xxxxxxxxx>
> Cc: microblaze-uclinux@xxxxxxxxxxxxxx
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Tony Luck <tony.luck@xxxxxxxxx>

Patch looks good - thanks!

Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/