Re: [RFC PATCH] kmemleak: Scan all thread stacks

[Peter Zijlstra]

On Fri, 2009-07-17 at 17:57 +0100, Catalin Marinas wrote:
> On Fri, 2009-07-17 at 18:43 +0200, Ingo Molnar wrote:
> > * Catalin Marinas <catalin.marinas@xxxxxxx> wrote:
> > > 2. Is it safe to use rcu_read_lock() and task_lock() when scanning the
> > >    corresponding kernel stack (thread_info structure)? The loop doesn't
> > >    do any modification to the task list. The reason for this is to
> > >    allow kernel preemption when scanning the stacks.
> > 
> > you cannot generally preempt while holding the RCU read-lock.
> 
> This may work with rcupreempt enabled. But, with classic RCU is it safe
> to call schedule (or cond_resched) while holding the RCU read-lock?

No.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/