Re: [PATCH] page-allocator: Ensure that processes that have beenOOM killed exit the page allocator (resend)

[David Rientjes]

On Fri, 17 Jul 2009, Mel Gorman wrote:

> Ok, lets go with this patch then. Thanks
> 

Ok, thanks, I'll add that as your acked-by and I'll write a formal patch 
description for it.


mm: avoid endless looping for oom killed tasks

If a task is oom killed and still cannot find memory when trying with no 
watermarks, it's better to fail the allocation attempt than to loop 
endlessly.  Direct reclaim has already failed and the oom killer will be a 
no-op since current has yet to die, so there is no other alternative for 
allocations that are not __GFP_NOFAIL.

Acked-by: Mel Gorman <mel@xxxxxxxxx>
Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>
---
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1789,6 +1789,10 @@ rebalance:
 	if (p->flags & PF_MEMALLOC)
 		goto nopage;
 
+	/* Avoid allocations with no watermarks from looping endlessly */
+	if (test_thread_flag(TIF_MEMDIE) && !(gfp_mask & __GFP_NOFAIL))
+		goto nopage;
+
 	/* Try direct reclaim and then allocating */
 	page = __alloc_pages_direct_reclaim(gfp_mask, order,
 					zonelist, high_zoneidx,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/