Re: [RFC patch] delete improper hot pluggable code of memory affinity

[Luming Yu]

On Fri, Jul 17, 2009 at 1:52 PM, Yasunori Goto<y-goto@xxxxxxxxxxxxxx> wrote:
>> Without a fix like my proposal, I have seen NUMA configure disabled by
>> kernel (due to the code the patch deletes) on a system with Enabled
>> bit set , and Hotplug-able bit cleared, and
>> CONFIG_MEMORY_HOTPLUG_SPARSE disabled.
>
> Ok. I guess that save_add_info() was to check percentage of
> reserve area when CONFIG_MEMORY_HOTPLUG_RESERVE is set.
> Its code was removed at 2.6.25, save_add_info() may be garbage now.
>
> However, I have one question now.
>
>>> - Â Âif (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
>>> - Â Â Â Â Â Âupdate_nodes_add(node, start, end);
>>> - Â Â Â Â Â Â/* restore nodes[node] */
>>> - Â Â Â Â Â Â*nd = oldnode;
>>> - Â Â Â Â Â Âif ((nd->start | nd->end) == 0)
>>> - Â Â Â Â Â Â Â Â Â Ânode_clear(node, nodes_parsed);
>>> - Â Â }
>
> I don't understand why you remove this code. could you tell me why?

Good question. This is exactly the place I'm puzzled too.
Without delete this code, I still see one fake node instead of 4 real node...
I think a flow up patch is needed here...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/