Re: [PATCH] Restructure BSS linker script macros.

[Tim Abbott]

On Thu, 16 Jul 2009, Sam Ravnborg wrote:

> On Sun, Jul 12, 2009 at 06:23:33PM -0400, Tim Abbott wrote:
> > I'd like acks from Sam and David on this one.  Also CCing Paul, since
> > he has a patch from me which will need to be updated to use
> > BSS_SECTION(0, PAGE_SIZE, 4) once this gets merged.
> 
> Path looks good - this is howit should have looked in the first place.
> I recall that the alignmnet of 4 came from what is default for ld at least
> for i386 but it really is dependent on the routine that clears the bss
> section so we better make it configurable. Some archs may prefer to clear
> bss in 8 byte chunks...

Right, e.g. avr32 uses 8 for this.

> Could you please resend including the necessary fix for mn10300 so we do not
> break bisecting.

I don't understand what you're asking here.  The original patch I sent 
does include the necessary fix for mn10300 in the first hunk (reproduced 
below).  I intentionally changed the mn10300 use at the same time as 
changing the macros in order to avoid breaking bisecting.

I'd be happy to resend if it'd be helpful.

--- a/arch/mn10300/kernel/vmlinux.lds.S
+++ b/arch/mn10300/kernel/vmlinux.lds.S
@@ -107,7 +107,7 @@ SECTIONS
   __init_end = .;
   /* freed after init ends here */
 
-  BSS(4)
+  BSS_SECTION(0, PAGE_SIZE, 4)
 
   _end = . ;
 


	-Tim Abbott


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/