Re: [PATCH 02/20] ceph: on-wire types

[Andi Kleen]

Sage Weil <sage@xxxxxxxxxxxx> writes:
> +
> +/*
> + * Max file size is a policy choice; in reality we are limited
> + * by 2^64.
> + */
> +#define CEPH_FILE_MAX_SIZE (1ULL << 40)   /* 1 TB */

Seems odd to hardcode this here.

The way attribute packed is used in these files seems rather
random and adhoc, sometimes it is, sometimes it isn't.

I assume you tested that 32bit and 64bit interoperability?

Is the file system supposed to be endian safe on the wire?

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/