Re: [PATCH #tj-block-for-linus] block: fix failfast merge testingin elv_rq_merge_ok()

[Tejun Heo]

Boaz Harrosh wrote:
> OK So could you put a FIXME: and fat comment, on that weird "!"(s)
> everywhere?

Yeap, sure.  How about something like the following?

	/*
	 * Don't merge if failfast settings don't match.  The negation
	 * in front of each condition is necessary because bio and
	 * request flags use different bit positions and the accessors
	 * return those bits directly.  This ugliness will soon go
	 * away.
	 */

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/