Re: security_file_lock cmd argument

From: Sten Spans
Date: Thu Jul 16 2009 - 03:42:33 EST


On Thu, Jul 16, 2009 at 10:05:47AM +1000, James Morris wrote:
> > From: Sten Spans <Sten_Spans@xxxxxxxx>
>
> This looks good, but you need to add a signed-off-by line per
> Documentation/SubmittingPatches
>

Makes sense, how about:

Pass posix-translated lock operations to security_file_lock
when invoked via sys_flock.

Signed-off-by: Sten Spans <Sten_Spans@xxxxxxxx>

--- fs/locks.c.orig 2009-07-09 11:26:45.000000000 +0200
+++ fs/locks.c 2009-07-09 11:27:24.000000000 +0200
@@ -1590,7 +1590,7 @@
if (can_sleep)
lock->fl_flags |= FL_SLEEP;

- error = security_file_lock(filp, cmd);
+ error = security_file_lock(filp, lock->fl_type);
if (error)
goto out_free;

--
GeNUA Gesellschaft für Netzwerk - und Unix-Administration mbH
Domagkstr. 7, D-85551 Kirchheim. http://www.genua.de
Tel: (089) 99 19 50-0, Fax: (089) 99 19 50 - 999

Geschäftsführer: Dr. Magnus Harlander, Dr. Michaela Harlander,
Bernhard Schneck. Amtsgericht München HRB 98238
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/