Re: [PATCH 1/1] i915: fix up a raw 64bit divide

From: Sergio Luis
Date: Sun Jul 05 2009 - 06:19:12 EST


On Wed, Jul 1, 2009 at 1:12 PM, Jesse Barnes<jbarnes@xxxxxxxxxxxxxxxx> wrote:
> On Wed,  1 Jul 2009 15:20:59 +0100
> Andy Whitcroft <apw@xxxxxxxxxxxxx> wrote:
>
>> We are seeing compilation failures on i386 in some environments due
>> to an undefined reference as below:
>>
>>     ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined!
>>
>> This is generated due to a raw 64 bit divide in the i915 driver.  Fix
>> up this raw divide.
>>
>> Signed-off-by: Andy Whitcroft <apw@xxxxxxxxxxxxx>
>
> I think building with newer GCCs will prevent this error, but the fix
> looks fine.

I get it in here (31-rc2), with gcc 4.2.4, but only if I have
CONFIG_DEBUG_SECTION_MISMATCH=y. With this patch it works regardless
of that option.

>
> Acked-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
>
> --
> Jesse Barnes, Intel Open Source Technology Center
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/