Re: [BUG 2.6.31-rc1] HIGHMEM64G causes hang in PCI init on 32-bitx86

[H. Peter Anvin]

Yinghai Lu wrote:
> H. Peter Anvin wrote:
>> Yinghai Lu wrote:
>>> agreed, that is why we change round_up to take u64.
>>>
>> round_up() is a macro, it doesn't "take" anything per se...
>>
> i mean
>  end = roundup(start, ram_alignment(start)) - 1;
> 
> static u64 ram_alignment(u64 pos)
> 
> and other calling to round_up
> 

This is fixing the wrong problem.  Fixing round_up is the right thing,
not working around its brain damage.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/