Re: [PATCH 3/9] x86/moorestown: add moorestown platform flags

[Alan Cox]

> We will gladly take clean x86 patches that abstract away lowlevel 
> details of x86 platforms, and have been taking them and have been 
> writing them for a long time. If this patch-set can shape itself in 
> such a way (as i requested), without hindering the common case, it 
> is certainly welcome.

Lets try again shall we. I'l repeat the relevant bits of the mail you
quoted bits from and ignored almost all of

> The thing is, you are trying to defend a v1 patch-set here that is 
> really indefensible: it's ugly and deficient in numerous smaller and 
> larger details. I outlined numerous deficiencies already - and i'll 
> review v2 too to see what else is there to fix.  

No I'm trying to understand what you actually want the thing to look like.
Are we talking

/* Fixed struct not pointer for speed */
struct platform_ops platform_ops;
memcpy(platform_ops, platform_op_list[detect_platform_type()],
					sizeof(struct platform_ops));

platform->add_private_resources();
platform->timer_foo();
platfomr->timer_bar();

or

platform->init();
timer = platform->timer;

timer->begin()

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/