Re: [uClinux-dev] [PATCH] m68k: restore lost coldfireCLOCK_TICK_RATE

From: Philippe De Muyter
Date: Wed Jun 24 2009 - 17:12:00 EST


Hi Greg,

On Mon, Jun 22, 2009 at 01:18:55PM +1000, Greg Ungerer wrote:
> HI Philippe,
>
> Philippe De Muyter wrote:
>> Hello list,
>> The good definition of CLOCK_TICK_RATE for coldfires has been lost in the
>> merge of m68k and m68knommu include files. Restore it. Culprit :
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ebafc17468d58bd903c886175ca84a4edc69ae1d;hp=34055b806a6334624e7e8af6eefc3aee42372a85
>> Signed-off-by: Philippe De Muyter <phdm@xxxxxxxxx>
>
> Is it needed?
> What is broken with the existing value?

I am no ntp expert, but IIRC kernel/time/ntp.c needs to know the remainder
of CLOCK_TICK_RATE / HZ to obtain a good stability of the time. That's
probably only needed when you have ntpd running.

Philippe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/