Re: Build failure latest git. (acl related)

From: Al Viro
Date: Wed Jun 24 2009 - 16:49:22 EST


On Wed, Jun 24, 2009 at 10:46:58PM +0200, Markus Trippelsdorf wrote:

> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 78ad38d..1f7aa6c 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -2122,10 +2122,12 @@ static void btrfs_read_locked_inode(struct inode *inode)
> * any xattrs or acls
> */
> maybe_acls = acls_after_inode_item(leaf, path->slots[0], inode->i_ino);
> +#ifdef CONFIG_FS_POSIX_ACL
> if (!maybe_acls) {
> inode->i_acl = NULL;
> inode->i_default_acl = NULL;
> }
> +#endif

Actually, I disagree with that one - it begs for a helper function instead
of ifdef. Give me a few...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/