Re: [RFC 2/7] crypto: Use GHASH digest algorithm in GCM

[Huang Ying]

On Thu, 2009-06-18 at 04:47 +0800, Sebastian Andrzej Siewior wrote:
> * Huang Ying | 2009-06-11 15:10:28 [+0800]:
> 
> >Remove the dedicated GHASH implementation in GCM, and uses the GHASH
> >digest algorithm instead. This will make GCM uses hardware accelerated
> >GHASH implementation automatically if available.
> >
> >ahash instead of shash interface is used, because some hardware
> >accelerated GHASH implementation needs asynchronous interface.
> The outside interface is also async so this should work.
> 
> >Signed-off-by: Huang Ying <ying.huang@xxxxxxxxx>
> >
> >@@ -796,14 +996,15 @@ static int __init crypto_gcm_module_init
> > 	if (err)
> > 		goto out_undo_gcm;
> > 
> >-out:
> >-	return err;
> >+	return 0;
> > 
> > out_undo_gcm:
> > 	crypto_unregister_template(&crypto_gcm_tmpl);
> > out_undo_base:
> > 	crypto_unregister_template(&crypto_gcm_base_tmpl);
> >-	goto out;
> >+out:
> >+	kfree(gcm_zeroes);
> >+	return err;
> > }
> > 
> > static void __exit crypto_gcm_module_exit(void)
> here you are leaking gcm_zeroes

Yes. I will change this. Thank you.

Best Regards,
Huang Ying

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/