Re: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or suspending

[Pekka Enberg]

Linus Torvalds wrote:
> On Fri, 12 Jun 2009, Pekka J Enberg wrote:
> > Hmm. This is turning into one epic patch discussion for sure! But here's a 
> > patch to do what you suggested. With the amount of patches I am 
> > generating, I'm bound to hit the right one sooner or later, no?-)
>
> Ok, this one looks pretty good. I like the statics, and I like how it lets 
> each allocator decide what to do.
>
> Small nit: your mm/slab.c patch does an obviously unnecessary mask in:
>
> 	cache_alloc_debugcheck_before(cachep, flags & slab_gfp_flags);
>
> but that's stupid, because the bits were already masked earlier.

Yeah, the SLAB parts were completely untested. I have this in my tree 
now (that I sent a pull request for):

http://git.kernel.org/?p=linux/kernel/git/penberg/slab-2.6.git;a=commitdiff;h=f6b726dae91cc74fb3a00f192932ec4fe0949875

Do you want me to drop it? I can also do an incremental patch to do the 
unmasking as in this patch.

			Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/