Re: [PATCH] init: introduce mm_init()

From: Pekka Enberg
Date: Thu Jun 11 2009 - 12:01:36 EST


Hi Linus,

On Thu, 2009-06-11 at 08:56 -0700, Linus Torvalds wrote:
> Please just put the comments at the top of the function in cases like
> this, ie just
>
> /*
> * ...
> */
> static int __init mm_init(void)
> {
> ..
> }

Fixed.

On Thu, 2009-06-11 at 08:56 -0700, Linus Torvalds wrote:
> also, I'm now terminally confused about the whole series, so I'm wondering
> if you could re-do the series so that (a) I have a clear picture of what
> to take, and (b) preferably so it's also all bisectable (ie the trap_init
> ordering fixes are done in the initial mm/init.c changes).

Yup, I will do that and send a v3 of the pull request. I am compiling a
kernel here to try out my tree on 32-bit. I think Ingo is busy preparing
his remaining merges now so I haven't gotten confirmation from him
whether my patch fixes the problem he saw or not.

Pekka

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/