Re: [PATCH -v5] x86: MCE: Re-implement MCE log ring buffer asper-CPU ring buffer

From: Huang Ying
Date: Mon Jun 08 2009 - 04:26:54 EST


On Mon, 2009-06-08 at 15:38 +0800, Ingo Molnar wrote:
> * Huang Ying <ying.huang@xxxxxxxxx> wrote:
>
> > On Mon, 2009-06-08 at 15:20 +0800, Ingo Molnar wrote:
> > > * Huang Ying <ying.huang@xxxxxxxxx> wrote:
> > >
> > > > Re-implement MCE log ring buffer as per-CPU ring buffer for better
> > > > scalability.
> > >
> > > this should be done using the generic ring-buffer code - see
> > > include/linux/ring_buffer.h. Having a private implementation in
> > > architecture code is not really acceptable.
> >
> > MCE log ring buffer need to be NMI-safe, while current generic
> > ring-buffer code is not NMI safe. [...]
>
> Then please work with Steve to make it NMI safe (or do so yourself)
> - i've Cc:-ed him - that way we help the core kernel: one of its
> essential facilities will get one more user. We dont put private,
> open-coded ring-buffer facilities into architecture code.

Steve have said he has a NMI-safe solution, but it is under patent
application. It seems that patent application will take very long time,
so we decide to enhance mce log buffer instead of waiting.

Best Regards,
Huang Ying

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/