Re: [patch -mmotm] oom: only oom kill exiting tasks with attached memory

From: Balbir Singh
Date: Sun Jun 07 2009 - 10:12:39 EST


On Sun, Jun 7, 2009 at 3:42 AM, David Rientjes<rientjes@xxxxxxxxxx> wrote:
> When a task is chosen for oom kill and is found to be PF_EXITING,
> __oom_kill_task() is called to elevate the task's timeslice and give it
> access to memory reserves so that it may quickly exit.
>
> This privilege is unnecessary, however, if the task has already detached
> its mm.  Although its possible for the mm to become detached later since
> task_lock() is not held, __oom_kill_task() will simply be a no-op in such
> circumstances.
>
> Subsequently, it is no longer necessary to warn about killing mm-less
> tasks since it is a no-op.
>
> Cc: Rik van Riel <riel@xxxxxxxxxx>
> Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>

Seems like a good change to make. Did you encounter this situation on
a real machine?

Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/