Re: [PATCH] dmi: sanity check BIOS tables

[Jeff Mitchell]

On Sun, Jun 7, 2009 at 4:57 AM, Jiri Slaby<jirislaby@xxxxxxxxx> wrote:
> On 06/07/2009 01:01 AM, Alan Cox wrote:
>> @@ -260,6 +276,11 @@ static void __init dmi_save_ipmi_device(const struct dmi_header *dm)
>> Â Â Â struct dmi_device *dev;
>> Â Â Â void * data;
>>
>> + Â Â if (((u8 *)dm) + dm->length > dmi_end) {
>
> I think this should be >= too.
>
>> + Â Â Â Â Â Â printk(KERN_ERR "dmi_save_ipmi_device: table overrun.\n");
>> + Â Â Â Â Â Â return;
>> + Â Â }
>> +

I've tried this patch, both with Jiri's suggestion and without.
Neither makes a difference, except for slightly changing the output (
new output at http://tinypic.com/r/2di4mlg/5 )

Let me know if I can provide anything more to help debug.

Thanks,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/