Re: [PATCH -tip] x86: cpu_debug.c prepare report if files areinappropriate or CPU is not supported

[Ingo Molnar]

* Jaswinder Singh Rajput <jaswinder@xxxxxxxxxx> wrote:

> Hello Ingo,
> 
> On Wed, 2009-04-15 at 12:17 +0200, Ingo Molnar wrote:
> 
> > The main beef i had with your code is that it copies CPU enumeration 
> > over into some local variables (cpu_modelflag, cpu_model) with 
> > redundant encodings and decodings which dont fully work.
> > 
> > Is there anything that your encoding/decoding does that cannot be 
> > done via the standard methods?
> > 
> 
> I removed cpu model info. May be this will create some issues on 
> ancient machine as now it depends on rdmsr_safe_on_cpu() and I 
> hope it will be safe ;-)

rdmsr_safe() should really be safe. (If it isnt then that primitive 
needs fixing, not the code that uses it.)

> Can you please check this patch on ancient and latest machines.
> 
> 
> [PATCH] x86: cpu_debug remove model information to reduce encoding-decoding
> 
> Remove model information, encoding/decoding and reduce bookkeeping.
> 
> Reported-by: Ingo Molnar <mingo@xxxxxxx>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
> ---
>  arch/x86/include/asm/cpu_debug.h |  101 +---------
>  arch/x86/kernel/cpu/cpu_debug.c  |  417 +++++++++-----------------------------
>  2 files changed, 97 insertions(+), 421 deletions(-)

This actually looks like to be a very nice cleanup as well, as can 
be seen from the massive line count reduction. I'll give it some 
testing.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/