Re: [PATCH] tracing/branch-tracer: PROFILE_BRANCHES_PER_CPU mustdepend on SMP

[Steven Rostedt]

On Sat, 6 Jun 2009, Frederic Weisbecker wrote:
> 
> [ Impact: fix a build failure with the branch tracer ]
> 
> Reported-by: Ingo Molnar <mingo@xxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> ---
>  kernel/trace/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 309a264..0efbcc5 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -285,7 +285,7 @@ endchoice
>  
>  config PROFILE_BRANCHES_PER_CPU
>  	bool "Profile branches on a per cpu basis"
> -	depends on PROFILE_ALL_BRANCHES
> +	depends on PROFILE_ALL_BRANCHES && SMP

You just wasted two minutes of my time!

I was just about to send out the same patch, but you beat me to it. ;-)

Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

-- Steve


>  	help
>  	  When profiling all branches, the system can take a big cache line
>  	  bouncing hit. On boxes with lots of CPUs, this can slow the system
> -- 
> 1.6.2.3
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/