Re: [PATCH 1/7] initdev:kernel:Asynchronously-discovered device synchronization,v6

From: Stefan Richter
Date: Sat Jun 06 2009 - 04:44:29 EST


David VomLehn wrote:
+Some rules about correct usage:
+o Each call to initdev_found *must* be matched by a call to
+ initdev_probe_done.

This would be useful as inline kerneldoc documentation at initdev_found().

+o The value of initdev_mask passed to initdev_found and
+ initdev_probe_done for a given device must be identical.

And this as kerneldoc at initdev_probe_done().

What happens if the calls or the call arguments aren't balanced, e.g. due to a mistake in an error path? The kernel will hang?

(BTW, much, though possibly not all, of the "History" section of your changelog should be below the --- delimiter, and the "v6" in the subject should be within the [PATCH ...] prefix.)
--
Stefan Richter
-=====-==--= -==- --==-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/