Re: [PATCH] x86: clean up vdso-layout.lds.S

[H. Peter Anvin]

Andi Kleen wrote:
>> Any comments on this? It doesn't change anything. It only makes it
>> harder to break vDSOs by accident (such as the latest buglet with TSC
>> synchronization).
> 
> Looks ok to me. Although it would have been nicer if you hadn't mixed
> that many changes together.
> 
> Acked-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> 

It would have.  That makes review harder, and right at the moment time
is a bit at a premium.  It looks like a good cleanup, but it also looks
like it's going to need some testing, which means that since it is not a
functional change I would feel best if we could put it on the .32 track
after the imminent merge window craziness is over.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/