Re: [PATCH] eeepc-laptop.c: use pr_fmt and pr_<level>

[Corentin Chary]

On Fri, Jun 5, 2009 at 6:07 PM, Joe Perches<joe@xxxxxxxxxxx> wrote:
> On Fri, 2009-06-05 at 18:01 +0200, Corentin Chary wrote:
>> On Fri, Jun 5, 2009 at 5:45 PM, Joe Perches<joe@xxxxxxxxxxx> wrote:
>> > On Fri, 2009-06-05 at 13:57 +0200, Corentin Chary wrote:
>> >> On Fri, Jun 5, 2009 at 1:00 PM, Joe Perches<joe@xxxxxxxxxxx> wrote:
>> >> > On Fri, 2009-06-05 at 11:54 +0100, Alan Jenkins wrote:
>> >> >> Is EEEPC_HOTK_FILE used anywhere else?  It would be clearer if you were
>> >> >> able to just use "eeepc: " or whatever and remove the definition of
>> >> >> EEEPC_HOTK_FILE.
>> >> > It is used elsewhere and perhaps it'd be better to use KBUILD_MODNAME.
>> >> I think we can't use KBUILD_MODNAME because "eeepc" is used for
>> >> platform_device, backlight and input device. Using "eeepc-laptop"
>> >> would break compatibility.
>> > What compatibility would it break?
>> > Logging messages are not guaranteed to be stable across versions.
>> for platform_device backlight and input device it would change the
>> "/sys" paths (eg: /sys/class/backlight/eeepc)
>
> I see what you mean.  We're talking cross purposes though.
> I meant that KBUILD_MODNAME be used for pr_fmt, not anywhere else.
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> So, no changes to any other EEPC_HOTK_FILE uses.
>
> cheers, Joe
>
>

Ah, ok. Sorry =)
Yeah sure we could use KBUILD_MODNAME  here. I'll just rework your
patch to change that if you don't mind.

-- 
Corentin Chary
http://xf.iksaif.net - http://uffs.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/