Re: [PATCH 3/5] net: add NL802154 interface for configuration of802.15.4 devices

[Dmitry Eremin-Solenikov]

On Fri, Jun 05, 2009 at 12:54:18AM -0700, David Miller wrote:
> From: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>
> Date: Fri, 5 Jun 2009 11:15:29 +0400
> 
> > On Fri, Jun 05, 2009 at 08:52:17AM +0200, Johannes Berg wrote:
> >> On Fri, 2009-06-05 at 06:29 +0400, Dmitry Eremin-Solenikov wrote:
> >> 
> >> > +/* This source file is shared between kernel and userspace sources, thus
> >> > + * a bit of __KERNEL__ checks
> >> > + */
> >> > +#ifdef __KERNEL__
> >> 
> >> It's a C file. It can't be shared expect by copying, hence IMO these
> >> things are pointless.
> > 
> > It is shared by copying. And I'd strongly prefer to have it shared
> > directly by 'cp', not by 'cp' and 'patch'. E.g. currently I can ensure
> > that policy definitions and commands are current just by comparing
> > files. I'd like to still have that ability. Thus, I'd ask to permit this
> > stuff in.
> 
> You can maintain your own code in your own directories in your
> own source tree however you like.
> 
> But if you want you code in the upstream kernel, you have to clean it
> of things like this.
> 
> I agree with Johannes, you have to get rid of this.

I've pushed an updated version with the following patch instead of
the original one.