Re: [2.6.30-rc8] gcc 3.3 : __udivdi3 undefined.

[Tetsuo Handa]

Andrew Morton wrote:
> We could do the obvious:
> 
> --- a/arch/x86/mm/memtest.c~a
> +++ a/arch/x86/mm/memtest.c
> @@ -8,6 +8,7 @@
>  #include <linux/pfn.h>
>  
>  #include <asm/e820.h>
> +#include <asm/div64.h>
>  
>  static u64 patterns[] __initdata = {
>  	0,
> @@ -48,7 +49,8 @@ static void __init memtest(u64 pattern, 
>  
>  	incr = sizeof(pattern);
>  	start_phys_aligned = ALIGN(start_phys, incr);
> -	count = (size - (start_phys_aligned - start_phys))/incr;
> +	count = size - (start_phys_aligned - start_phys);
> +	do_div(count, incr);
>  	start = __va(start_phys_aligned);
>  	start_bad = 0;
>  	last_bad = 0;

"make" of "make allmodconfig" + CONFIG_KVM=n on gcc 3.3.5 completed
successfully.

>but I wonder why all those things are u64.  They all hold virtual
>addresses, don't they?  The code doesn't test highmem.  So shouldn't
>these all be unsigned longs?
memtest() in linux-2.6.29.4/arch/x86/mm/memtest.c is using "unsigned long".
2.6.30 changed to use "u64" by some reason.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/