Re: [PATCH] cpumask: alloc blank cpumask left over

[Avi Kivity]

Rusty Russell wrote:
> On Fri, 5 Jun 2009 06:31:31 am Yinghai Lu wrote:
>   
> > avoid suprise when MAXSMP is enabled
> >
> > Signed-off-by: Yinghai Lu <yinghai.lu@xxxxxxxxxx>
> >     
>
> I understand the temptation, but two questions arise:
> 1) Shouldn't we actually audit to see if any of these are currently problems, 
> and
> 2) Should the non-MAXSMP alloc_cpumask_var_node (currently a noop) zero the 
> mask if __GFP_ZERO is set?
>   

If we go that route we should conditionally clear the bitmaps in 
alloc_cpumask_var().  I don't think we do, though.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/