Re: [PATCH 3/7] percpu: clean up percpu variable definitions

[Tejun Heo]

Benjamin Herrenschmidt wrote:
> On Mon, 2009-06-01 at 20:36 +0900, Tejun Heo wrote:
>>> Whether the volatile is actually needed or not, it's bad to have this
>>> kind of potential behavior changing nugget hidden in this seemingly
>>> inocuous change.  Especially if you're the poor soul who ends up
>>> having to debug it :-/
>> You're right.  Aieee... how do I feed volatile to the DEFINE macro.
>> I'll think of something.
> 
> Or better, work with the cris maintainer to figure out whether it's
> needed (it probably isn't) and have a pre-requisite patch that removes
> it before your series :-)

Yeap, that's worth giving a shot.

Mikael Starvik, can you please enlighten us why volatile is necessary
there?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/