Re: linux-next: ubi tree build failure

[Stephen Rothwell]

Hi Artem,

On Wed, 03 Jun 2009 14:26:46 +0300 Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx> wrote:
>
> Stephen Rothwell wrote:
> > Today's linux-next build (powerpc ppc44x_defconfig) failed like this:
> > 
> > drivers/mtd/ubi/gluebi.c: In function 'gluebi_get_device':
> > drivers/mtd/ubi/gluebi.c:126: error: implicit declaration of function 'IS_ERR'
> > drivers/mtd/ubi/gluebi.c:129: error: implicit declaration of function 'PTR_ERR'
> 
> It is strange that I do not see these errors on my x86_86

The above was a build for a 32 bit powerpc platform.  This is an instance
of a general issue when an API is used without explicitly including the
header files that define the API.  The needed header file may be included
by some convoluted path that depends on the architecture being built or
even the particular configuration.

> Any suggestions what I could do to reproduce the build issues?
> I'll try at least now to build this on x86 (32-bit). 

Always directly include the header files for APIs you use ...

I see that this particular problem is now fixed, thanks.
-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature