Re: [PATCH v2] kmap_types: convert most arches to a single header file

[Arnd Bergmann]

On Thursday 04 June 2009, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Subject: kmap_types: make most arches use generic header file
> 
> Convert most arches (*except frv*) to use asm-generic/kmap_types.h.
> Each arch still has its own kmap_types.h for customization if
> needed (like frv).
> 
> KM_FENCE is now controlled by CONFIG_HIGHMEM.
> 
> Built on x86_64, i386, mips, sparc32, sparc64,
> alpha, powerpc64, ia64, and m68k.
> 
> Note: Removed KM_PTE2 from generic kmap_types.h file; it was defined
> but not used by avr32.

Every change in here looks good to me now, so

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

Two questions though:

1. The patch still conflicts with mine from the asm-generic
tree. Yours is better in multiple ways (cleans up all the
archs, adds the necessary types for ppc and arm), so should
I drop mine now? I guess I can also make my file identical
to yours so independent of who gets in first, there should be
a clean merge?

2. should the asm and powerpc bits go through the arch maintainer
trees? I guess since they are slightly more than an obvious
consolidation, at least an Ack from BenH and Russell would be
appropriate.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/