Re: [PATCH] perfcounter: sleep before refresh using poll in perftop

[Ingo Molnar]

* Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

> perf top is refreshed every delay_secs the thread runs in such
> loop:
> 
> while (sleep(delay_secs)) {
> 	print_sym_table();
> }
> 
> At the end of print_sym_table(), poll is used without sleep delay
> to check if we have something from stdin.
> 
> It means that this check is done only every delay_secs, which can
> be higher that 2 secs if the user defined a custom refresh rate.
> 
> We can drop sleep() here and directly use poll to wait between
> refresh periods, so that the reaction after the user stops perf top
> after typing "Enter" is immediate and doesn't suffer from the
> delay_secs latency.
> 
> Nb: poll doesn't add any overhead that can parasite perf top measures
> since it sleeps the entire timeout here.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> ---
>  Documentation/perf_counter/builtin-top.c |   18 ++++++++----------
>  1 files changed, 8 insertions(+), 10 deletions(-)

Applied, thanks a lot Frederic!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/