Re: [PATCH 4/6] net: add NL802154 interface for configuration of802.15.4 devices

[Dmitry Eremin-Solenikov]

On Wed, Jun 03, 2009 at 03:09:11AM -0700, David Miller wrote:
> From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> Date: Wed, 03 Jun 2009 11:39:24 +0200
> 
> > On Wed, 2009-06-03 at 13:33 +0400, Dmitry Eremin-Solenikov wrote:
> > 
> >> +enum {
> >> +	__IEEE802154_COMMAND_INVALID,
> >> +
> >> +	IEEE802154_ASSOCIATE_REQ,
> >> +	IEEE802154_ASSOCIATE_CONF,
> >> +	IEEE802154_DISASSOCIATE_REQ,
> >> +	IEEE802154_DISASSOCIATE_CONF,
> >> +	IEEE802154_GET_REQ,
> >> +	IEEE802154_GET_CONF,
> >> +/* 	IEEE802154_GTS_REQ, */
> >> +/* 	IEEE802154_GTS_CONF, */
> >> +	IEEE802154_RESET_REQ,
> >> +	IEEE802154_RESET_CONF,
> >> +/* 	IEEE802154_RX_ENABLE_REQ, */
> >> +/* 	IEEE802154_RX_ENABLE_CONF, */
> > 
> > This is a recipe for disaster. Somebody will come along and uncomment
> > things. Why this is bad, I leave as an exercise for the reader.
> 
> Right, it changes the other request numbers and breaks userspace.
> 
> Dmitry you have to pick these numbers as fixed numbers now and do
> so in such a way that they will remain unchanged forever because
> they are part of the user visible interface.