Re: [PATCH 2/6] Add constants for the ieee 802.15.4/ZigBee stack

[Dmitry Eremin-Solenikov]

On Wed, Jun 03, 2009 at 03:08:26AM -0700, David Miller wrote:
> From: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>
> Date: Wed,  3 Jun 2009 13:33:45 +0400
> 
> > IEEE 802.15.4/ZigBee stack requires several constants to be defined/adjusted.
> > 
> > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>
> > Signed-off-by: Sergey Lapin <slapin@xxxxxxxxxxx>
> > ---
> >  include/linux/if.h       |    2 ++
> >  include/linux/if_arp.h   |    2 ++
> >  include/linux/if_ether.h |    2 ++
> >  include/linux/socket.h   |    6 +++++-
> >  net/core/dev.c           |    6 ++++--
> >  net/core/sock.c          |    3 +++
> >  6 files changed, 18 insertions(+), 3 deletions(-)
> > 
> > diff --git a/include/linux/if.h b/include/linux/if.h
> > index 1108f3e..3f574b8 100644
> > --- a/include/linux/if.h
> > +++ b/include/linux/if.h
> > @@ -68,6 +68,8 @@
> >  #define IFF_MASTER_ARPMON 0x100		/* bonding master, ARP mon in use */
> >  #define IFF_WAN_HDLC	0x200		/* WAN HDLC device		*/
> >  
> > +#define IFF_IEEE802154_COORD 0x100	/* IEEE802.15.4 PAN coordinator */
> > +
> >  #define IF_GET_IFACE	0x0001		/* for querying only */
> >  #define IF_GET_PROTO	0x0002
> >  
> 
> This constant isn't used by any of these patches, and it's
> value overlaps that of IFF_MASTER_ARPMON  so would need to be
> changed anyways.
> 
> I didn't check if other things in this patch turn out to
> be unused as well, please audit that.

Please check the updated patch. We do request several unused in this
serie value (like AF_ZIGBEE), but we'd like for them to be merged ASAP
as their are a part of ABI.