Re: [PATCH 4/6] net: add NL802154 interface for configuration of802.15.4 devices

[Johannes Berg]

On Wed, 2009-06-03 at 13:33 +0400, Dmitry Eremin-Solenikov wrote:

> +enum {
> +	__IEEE802154_COMMAND_INVALID,
> +
> +	IEEE802154_ASSOCIATE_REQ,
> +	IEEE802154_ASSOCIATE_CONF,
> +	IEEE802154_DISASSOCIATE_REQ,
> +	IEEE802154_DISASSOCIATE_CONF,
> +	IEEE802154_GET_REQ,
> +	IEEE802154_GET_CONF,
> +/* 	IEEE802154_GTS_REQ, */
> +/* 	IEEE802154_GTS_CONF, */
> +	IEEE802154_RESET_REQ,
> +	IEEE802154_RESET_CONF,
> +/* 	IEEE802154_RX_ENABLE_REQ, */
> +/* 	IEEE802154_RX_ENABLE_CONF, */

This is a recipe for disaster. Somebody will come along and uncomment
things. Why this is bad, I leave as an exercise for the reader.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part