Re: [PATCH] Acer Aspire One Fan Control

[Peter Feuerer]

Hi,

Borislav Petkov writes:

> Hi,
>
> On Mon, Jun 01, 2009 at 04:12:21PM +0200, Peter Feuerer wrote:
> > > Ok, minor nitpicks below but it starting to shape up quite ok. You could
> > > send it for inclusion upstream.
> >
> > How exactly do I send the patch for inclusion?
>
> just rediff it against latest git and send an email to Len Brown (i
> assume, from looking at git log drivers/thermal/ output) requesting for
> driver inclusion.
>
> Len?
>
> If you hurry and do it this week it might be possible to get it in .31
> because the merge window opens around the coming weekend.

Ok, I'll try to directly address len with subject "Request driver inclusion 
acer aspire one fan control" and send a diff against latest git, right? 
(CC'ing lkml of course). Just wondering if it'll work, as Len has always 
been included via CC into our discussions and has never said anything :-(

> > > > +			acerhdf_notice("temp %d\n", temp);
> > > > +		return temp;
> > > > +	}
> > > > +	return ACERHDF_ERROR;
> > > > +}
> > > > +
> > > > +
> > > > +		if (verbose)
> > > > +			acerhdf_error("read state: %d expected state: %d\n",
> > > > +					old_state, fanstate);
> > > > +
> > > > +		acerhdf_change_fanstate(ACERHDF_FAN_AUTO);
> > > > +		disable_kernelmode = 1;
> > > > +	}
> > > > +
> > > > +	if (state == 0) {
> > > > +		/* turn fan off only if below fanoff temperature */
> > > > +		if ((old_state == ACERHDF_FAN_AUTO) &&
> > > > +				(acerhdf_get_temp() < fanoff))
> > >
> > > it might be cool to tell the user why you're not turning off the fan.
> > >
> > > 		if (verbose)
> > > 			acerhdf_notice("Not turning off fan due to current temp "
> > > 				       "exceeding fanoff value\n");
> >
> > Hm.. I think it should be clear that the fan is turned off, as soon as 
> > the temperature is below the fanoff temperature. In my opinion printing 
> > this message would be a case for a "verbose==2" verbose mode :)
>
> My reasoning was that because this is called from sysfs and the user
> sees nothing happening even if he'd turned off the fan by calling
> .set_cur_state that it might be useful to tell him why.

But the user isn't allowed to change the fan state from userspace anymore. 
If you try to change the fan state from userspace you'll get the "changing 
fan state is not allowed" message.

best regards,
--peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/