Re: [PATCH 0/11] Per-bdi writeback flusher threads v9

[Artem Bityutskiy]

Jens Axboe wrote:
> > Just to make sure I understood you correctly. I assume my original
> > patch is fine (because there is bdi_destroy()) and merge it to
> > ubifs tree.
>
> It needs to be:
>
>         err = bdi_register(&c->bdi, NULL, "ubifs");
>         if (err)
>                 goto out_bdi;
>
> so you hit the bdi_destroy() for that failure, not goto out_close;
> Otherwise it was fine.

Ah, I see. Rather non-typical convention though. I expected
bdi_register() to clean-up stuff in case of failure. Isn't
it a better interface?

--
Best Regards,
Artem Bityutskiy (ÐÑÑÑÐ ÐÐÑÑÑÐÐÐ)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/