Re: [PATCH] debugfs: use specified mode to possibly mark filesread/write only

From: Greg KH
Date: Tue Jun 02 2009 - 19:30:18 EST


On Tue, Jun 02, 2009 at 03:00:47AM -0400, Mike Frysinger wrote:
> From: Robin Getz <rgetz@xxxxxxxxxxxxxxxxxxxx>
>
> In many SoC implementations there are hardware registers can be read or
> write only. This extends the debugfs to enforce the file permissions for
> these types of registers by providing a set of fops which are read or
> write only. This assumes that the kernel developer knows more about the
> hardware than the user (even root users) -- which is normally true.
>
> Signed-off-by: Robin Getz <rgetz@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
> Signed-off-by: Bryan Wu <cooloney@xxxxxxxxxx>
> ---
> you mention debugfs header file changes, but i don't see what would need
> changing ? the mode checking is all done internally ...

Looks good to me.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/