Re: [PATCH 04/11] Blackfin SPORT UART: fix overrun errors

From: Alan Cox
Date: Tue Jun 02 2009 - 05:05:31 EST


On Tue, 2 Jun 2009 03:11:33 -0400
Mike Frysinger <vapier@xxxxxxxxxx> wrote:

> From: Cliff Cai <cliff.cai@xxxxxxxxxx>
>
> Push the ty_flip_buffer_push() call from the IRQ handler to a timer so as
> to improve performance and decrease likelihood of overruns.

This should have no effect on a modern kernel. There is 64K of queueing
between you and the ldisc nowdays. Furthermore unless you set
tty->low_latency the kernel already basically does this aggregation for
you as the buffer push queues stuff for the ldisc to wake up and process.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/