Re: [RFC patch] reset TSC at the begining of check_tsc_warp

From: Luming Yu
Date: Tue Jun 02 2009 - 03:06:03 EST


On Tue, Jun 2, 2009 at 7:10 AM, Frans Pop <elendil@xxxxxxxxx> wrote:
> Luming Yu wrote:
>> Without this patch, we always get kernel warning that TSC warp between
>> CPUs, and TSC is marked unstable due to check_tsc_sync_source failed if
>> the CPUs have the problem of not-synced initial TSC.
>>
>> It hurts CPUs with constant-tsc feature, but with unsynced initial TSC
>> value...
>>
>> The downside is we could break perfect synced TSC with this patch.
>> Please review, test and apply.
>
> I've tested this on my desktop (working TSC) and my laptop (non-working TSC).
> On both machines the patch didn't make any difference.

Thanks for testing, but if there was no warnings like
"Measured 439164 cycles TSC warp between CPUs, turning off TSC clock."
the patch won't help....

--Luming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/