Re: [PATCH 2/5] TOMOYO: Clarify lock protected section.

From: James Morris
Date: Tue Jun 02 2009 - 01:09:10 EST


On Tue, 2 Jun 2009, Tetsuo Handa wrote:

> I intended to help reviewers to visualize the range of protected section
> at a glance. But if reviewers feel noisy, I can remove these markers.

The lock functions act as annotations, you don't need to add any more.

Only add comments if the code is not obvious, but also first ask whether
this might mean that there's something wrong.

--
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/