Re: [PATCH 1/2] tracing/events: put TP_fast_assign into braces

[Steven Rostedt]

On Mon, 1 Jun 2009, Li Zefan wrote:

> Currently TP_fast_assin has a limitation that we can't define local
> variables in it.
> 
> Here's one use case when we introduce __dynamic_array():
> 
> TP_fast_assign(
> 	type *p = __get_dynamic_array(item);
> 
> 	foo(p);
> 	bar(p);
> ),
> 
> [ Impact: allow defining local variables in TP_fast_assign ]
> 
> Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx>

Thanks Li,

I'll pull it in.

-- Steve

> ---
>  include/trace/ftrace.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h
> index 9276ec4..ee92682 100644
> --- a/include/trace/ftrace.h
> +++ b/include/trace/ftrace.h
> @@ -471,7 +471,7 @@ static void ftrace_raw_event_##call(proto)				\
>  		return;							\
>  	entry	= ring_buffer_event_data(event);			\
>  									\
> -	assign;								\
> +	{ assign; }							\
>  									\
>  	if (!filter_current_check_discard(event_call, entry, event))	\
>  		trace_nowake_buffer_unlock_commit(event, irq_flags, pc); \
> -- 
> 1.5.4.rc3
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/