Re: [Fwd: Re: [PATCH]:RESEND : Return proper error value on failureof dentry_open]

[Jiri Slaby]

On 06/01/2009 11:46 AM, vibi sreenivasan wrote:
>>>>  	mutex_unlock(&iint->mutex);
>>>> -	if (file)
>>>> +	if (!IS_ERR(file))
>>>>  		fput(file);
>>>
>>> No, IS_ERR won't catch NULL and there is 'file = NULL' on the
>>> dentry_open fail path.
> Can you please point out that line number in fs/open.c

Aha, you use linus's git. This has been fixed by
f06dd16a03f6f7f72fab4db03be36e28c28c6fd6
(IMA: Handle dentry_open failures)
in -next.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/