Re: [PATCH] x86: add specific support for Intel Atom architecture

[Andi Kleen]

Tobias Doerffel <tobias.doerffel@xxxxxxxxx> writes:

> This adds another option when selecting CPU family so the kernel can
> be optimized for Intel Atom CPUs. If GCC supports tuning options for
> Intel Atom they will be used.

You seem to have ignored the earlier review feedback?

Like

> diff --git a/arch/x86/include/asm/module.h b/arch/x86/include/asm/module.h
> index 47d6274..e959c4a 100644
> --- a/arch/x86/include/asm/module.h
> +++ b/arch/x86/include/asm/module.h
> @@ -28,6 +28,8 @@ struct mod_arch_specific {};
>  #define MODULE_PROC_FAMILY "586MMX "
>  #elif defined CONFIG_MCORE2
>  #define MODULE_PROC_FAMILY "CORE2 "
> +#elif defined CONFIG_MATOM
> +#define MODULE_PROC_FAMILY "ATOM "

This is not needed because Atom is compatible to CORE2 (except for
one instruction the kernel doesn't use)

+	cflags-$(CONFIG_MATOM) += $(call cc-option,-march=atom) \
+		$(call cc-option,-mtune=atom,$(call cc-option,-mtune=generic))

It's doubtful that tune=generic is the best fallback for Atom, likely
tune=p5 is better


-Andi
-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/