Re: [PATCH]:Return proper error value on failure of dentry_open

[vibi sreenivasan]

hi,
	thanks for pointing that out.
> >  out:
> >  	mutex_unlock(&iint->mutex);
> > -	if (file)
> > +	if (IS_ERR(file))
> >  		fput(file);
extremely sorry it was 
	if(!IS_ERR(file))
		fput(file);
i will send that patch again

> 
> This makes no sense at all. If it is IS_ERR, i.e. some negative value,
> you don't want to pass it to fput. 'if (file)' was perfectly correct.
	if(file) is true for file != 0 , ie even if file is a -ve error
	value.
	so while fput dereference file ,this can cause a bug to be
	triggered.
	I actually had one.

Thanks & regards
vibi sreenivasan
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/