Re: [PATCH 25/20] sysfs: Only support removing emtpy sysfs directories.

[Kay Sievers]

On Sat, May 23, 2009 at 22:13, Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
> From: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
>
> I have looked and I have not found a single legitimate case today where
> we remove sysfs directories with anything in them. ÂThe only case I have
> found to date was a bug. ÂIt was a problem of ownership. ÂThe files in
> the directory where not owned by the directory itself. Â Leaving open
> the potential for double deletion of the directory contents.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxxxxxxxx>

Sounds good to me. We should try that, and see if there was any valid
use case we didn't think of, and if not, it's good to do what this
patch does.

Acked-by: Kay Sievers <kay.sievers@xxxxxxxx>

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/